fix: handle pg_replication_slots/pg_stat_replication on replicas and cascading replicas#548
Closed
michael-todorovic wants to merge 2 commits intoprometheus-community:masterfrom
Closed
Conversation
michael-todorovic
force-pushed
the
fix/github-547
branch
from
a49c20d to
11ab5cc
Compare
dan-aksenov
approved these changes
Jun 29, 2021
dan-aksenov
left a comment
dan-aksenov
left a comment
There was a problem hiding this comment.
Seems fine to me. At least for versions ">=10.0.0"
|
Is there any chance to get review by someone with write access? |
|
Any news? |
mblp
approved these changes
Sep 11, 2023
michael-todorovic
force-pushed
the
fix/github-547
branch
from
11ab5cc to
e3eaa91
Compare
…cascading replicas Signed-off-by: Michael Todorovic <michael.todorovic@outlook.com>
michael-todorovic
force-pushed
the
fix/github-547
branch
from
1cce3e9 to
e7fdba2
Compare
Contributor
Author
|
@mblp I just rebased this MR, basically moving my changes to queries.go. |
Contributor
Author
|
Bump, can some review and merge this? |
|
Can some review and merge this? |
|
What are we missing to get this merged? |
Contributor
Author
|
Actually there's a better change that #914 gets merged as there was more activity on that MR. This is the same exact code now 😂 |
Contributor
|
Merged via #1048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR aims to fix #547 where
pg_replication_slotsandpg_stat_replicationmetrics don't work well on replicas and cascading replicas (also known as standby leaders on Patroni). This allows standby clusters replication to be monitored :)It has been tested on pg 13, 10.7 and 9.6